2018-02-15 8:45 GMT+03:00 Jeff King <p...@peff.net>: > On Mon, Feb 12, 2018 at 08:08:54AM +0000, Olga Telezhnaya wrote: > >> Remove mark_atom_in_object_info() and create same logic >> in terms of ref-filter style. > > This one is definitely a step in the right direction. In fact, this is > what I would have expected to see in the beginning. It seems like this > first half of the series really would benefit from being squashed into a > few commits. I.e., I'd have expected to see the whole series looking > something like: > > - preparatory cleanup of ref-filter > > - teach ref-filter any new atoms (or atom options) that cat-file knows > about but it doesn't > > - convert cat-file to use ref-filter > > Most of what I've seen so far is basically that second step, but strung > out along a bunch of commits. Can we compact it into a few commits that > all make clear forward progress (by using "rebase -i" with "squash")?
I am afraid that I don't really see any 100% improvements by squashing some of the commits. I tried to do that several times and I squashed some of them, but now for me it looks like nothing else could be squashed so that commits still look close to making atomic changes (I am sure that it's super important). > > -Peff
