On Tue, Feb 6, 2018 at 5:12 PM, Brandon Williams <bmw...@google.com> wrote:

> +static void pack_line(const char *line)
> +{
> +       if (!strcmp(line, "0000") || !strcmp(line, "0000\n"))

>From our in-office discussion:
v1/v0 packs pktlines twice in http, which is not possible to
construct using this test helper when using the same string
for the packed and unpacked representation of flush and delim packets,
i.e. test-pkt-line --pack $(test-pkt-line --pack 0000) would produce
'0000' instead of '00090000\n'.
To fix it we'd have to replace the unpacked versions of these pkts to
something else such as "FLUSH" "DELIM".

However as we do not anticipate the test helper to be used in further
tests for v0, this ought to be no big issue.
Maybe someone else cares though?

Reply via email to