On 01.01.13 23:07, Junio C Hamano wrote:
> What it checks looks like a good start, but the indentation of it
> (and the log message) seems very screwed up.
> I also have to wonder what's the false positive rate of this. When
> you are preparing a new test, you would ideally want a mode that
> checks only parts that you just added, without seeing noises from
> existing violations and false positives from the part you did not
> touch. Otherwise, it will be too cumbersome to run for developers,
> and the check mechanism will end up used by nobody.
The script found all problems which make the testsuite (unecessary) fail on Mac
The false positive rate is currently 0% (otherwise I should not have send it to
The suggestion is to run it every time the test suite is run, at the begining.
And it seems to be fast enough:
$ time ./check-non-portable-shell.pl ../../git.master/t/t[0-9]*.sh
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html