On Wed, Jan 02, 2013 at 06:02:48PM -0800, Junio C Hamano wrote: > Torsten Bögershausen <tbo...@web.de> writes: > > > When the dust has settled, we can either enable the check always, > > or mention "make test-lint-shell-syntax" in the Documentation. > > In the longer term, I'm pretty much in favor of enabling all the > checks that are cheap by default, as that would help people catch > easy mistakes while preparing their patches. People do not tend to > enable any check if it were optional.
That is fine with me, and I always intended that we turn the lint on by default at some point (I'm not really sure why we didn't -- looking at the list archives, I think I did not push it because it seemed like nobody was really that interested). Certainly the two existing checks are cheap and do not produce false positives, and should be safe to turn on. Like this: -- >8 -- Subject: [PATCH] tests: turn on test-lint by default The test Makefile knows about a few "lint" checks for common errors. However, they are not enabled as part of "make test" by default, which means that many people do not bother running them. Since they are both quick to run and accurate (i.e., no false positives), there should be no harm in turning them on and helping submitters catch errors earlier. We could just set: TEST_LINT = test-lint to enable all tests. But that would be unnecessarily annoying later on if we add slower or less accurate tests that should not be part of the default. Instead, we name the tests individually. Signed-off-by: Jeff King <p...@peff.net> --- t/Makefile | 1 + 1 file changed, 1 insertion(+) diff --git a/t/Makefile b/t/Makefile index 3025418..5c6de81 100644 --- a/t/Makefile +++ b/t/Makefile @@ -13,6 +13,7 @@ DEFAULT_TEST_TARGET ?= test RM ?= rm -f PROVE ?= prove DEFAULT_TEST_TARGET ?= test +TEST_LINT ?= test-lint-duplicates test-lint-executable # Shell quote; SHELL_PATH_SQ = $(subst ','\'',$(SHELL_PATH)) -- 1.8.1.rc3.4.gf3a2f57 > -- > To unsubscribe from this list: send the line "unsubscribe git" in > the body of a message to majord...@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html