On Fri, Aug 03, 2018 at 05:33:17PM -0400, Eric Sunshine wrote:
> > +OPTIONS_SPEC="\
> > +doc-diff <from> <to> [-- diff options]
>
> Should this be?
>
> doc-diff [<options>] <from> <to> [-- <diff-options>]
I suppose so. Frankly I only added that line to appease git-sh-options
anyway.
> > +--
> > +j parallel argument to pass to make
> > +f force rebuild; do not rely on cached results
> > +"
>
> Should "j" and "f" be "-j" and "-f", respectively?
No, they're input to "rev-parse --parseopt".
> > +while test $# -gt 0
> > +do
> > + case "$1" in
> > + -j)
> > + parallel=${1#-j} ;;
> > + -f)
> > + force=t ;;
> > + --)
> > + shift; break ;;
> > + *)
> > + usage ;;
>
> There doesn't seem to a usage() function defined anywhere (and
> OPTIONS_SPEC doesn't seem to be used).
It's git-sh-setup automagic. Try "./doc-diff --foo"
> > +# We'll do both builds in a single worktree, which lets make reuse
> > +# results that don't differ between the two trees.
>
> "which lets make reuse"?
As in, lets the tool "make" reuse results...
-Peff
