On Sun, Aug 05, 2018 at 08:49:31PM +0000, brian m. carlson wrote:
> > +parallel=8
>
> I'm not sure -j8 is a great default. There are still a lot of
> two-core/four-thread machines out there, such as my laptop (from 2016).
> Maybe we should default this to 1 unless -j is provided, like make does.
I agree that "8" is arbitrary and probably not universally applicable. I
was just hoping to not have to say "-j8" every time I ran it (I already
"alias make='make -j8'" in my shell, but obviously it doesn't kick in
inside a script).
I guess some other options are:
1. Respect a config variable. Which seems funny, since this isn't a
git command.
2. Respect an environment variable (we already do a similar thing with
GIT_PERF_MAKE_OPTS, though it feels pretty clumsy).
I've also considered just setting MAKEFLAGS=-j8 in my environment,
but it always seemed like an abuse of a variable intended for
communicating between makes.
3. Default to number of CPUs, which is what a lot of other threading
in Git does. Unfortunately getting that from the shell is
non-trivial. I'm OK with $(grep -c ^processor /proc/cpuinfo), but
people on non-Linux platforms would have to fill in their own
implementation.
-Peff
