Torsten Bögershausen wrote: > On 20.01.13 12:06, Jonathan Nieder wrote: >> Torsten Bögershausen wrote: >> >>> I wonder, if if we can go one step further: >>> >>> Replace >>> #ifdef WIN32 /* Both MinGW and MSVC */ >> [...] >>> with >>> #if defined(_MSC_VER) >> >> I thought Git for Windows was built using mingw, which doesn't define >> _MSC_VER? >> >> Puzzled, >> Jonathan >> > Yes, > After removing these lines in the git-compat-util.h of msysgit > v1.8.1 it still compiled. > So I start to speculate if the comment is still valid for mingw, > or if that was true in the old days and not now any more. > > More investigation is needed, sorry for confusion.
Yes, I compiled the last patch on MinGW before I sent it to the list. I didn't bother with MSVC, since that build is already broken. I have a patch which fixed the MSVC build, but it already needs to be updated, since current master fails to build on MSVC. ATB, Ramsay Jones -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
