Re: [PATCH v2 04/11] fast-export: avoid dying when filtering by paths and old tags exist

[SZEDER Gábor]

On Tue, Nov 13, 2018 at 04:25:53PM -0800, Elijah Newren wrote:
> diff --git a/builtin/fast-export.c b/builtin/fast-export.c
> index af724e9937..b984a44224 100644
> --- a/builtin/fast-export.c
> +++ b/builtin/fast-export.c
> @@ -774,9 +774,12 @@ static void handle_tag(const char *name, struct tag *tag)
>                                       break;
>                               if (!(p->object.flags & TREESAME))
>                                       break;
> -                             if (!p->parents)
> -                                     die("can't find replacement commit for 
> tag %s",
> -                                          oid_to_hex(&tag->object.oid));
> +                             if (!p->parents) {
> +                                     printf("reset %s\nfrom %s\n\n",
> +                                            name, sha1_to_hex(null_sha1));

Please use oid_to_hex(&null_oid) instead.

> +                                     free(buf);
> +                                     return;
> +                             }
>                               p = p->parents->item;
>                       }
>                       tagged_mark = get_object_mark(&p->object);