On Wed, Jan 30, 2013 at 9:37 AM, Junio C Hamano <gits...@pobox.com> wrote:
> Junio C Hamano <gits...@pobox.com> writes:
>> Jonathan Nieder <jrnie...@gmail.com> writes:
>>> Brandon Casey wrote:
>>>> Round 3.
>>> Thanks for a pleasant read. My only remaining observations are
>>> cosmetic, except for a portability question in Duy's test script, a
>>> small behavior change when the commit message ends with an
>>> RFC2822-style header with no trailing newline and the possibility of
>>> tightening the pattern in sequencer.c to match the strictness of
>>> format-patch (which could easily wait for a later patch).
>> Thanks for a quick review. I agree that this series is getting very
>> close with your help.
> Unless Brandon and/or Jonathan wants to have another chance to
> excise warts from the recorded history by rerolling the entire
> series one more time, I think what we have queued is in a good
> enough shape to merge to 'next' and any further improvement and fix
> can be done incrementally.
> OK? Or "stop, I want to reroll"?
> I'll wait for a day or two.
Let's hold off so I can do another round. I worked on this last night
and was able to simplify some things nicely. I'll try to finish up
tonight and resubmit.
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html