[PATCH 21/26] bisect--helper: retire `--bisect-write` subcommand

[Pranit Bauva via GitGitGadget]

From: Pranit Bauva <pranit.ba...@gmail.com>

The `--bisect-write` subcommand is no longer used in the shell script
and the function `bisect_write()` is called from the C implementation.

Mentored-by: Lars Schneider <larsxschnei...@gmail.com>
Mentored-by: Christian Couder <chrisc...@tuxfamily.org>
Mentored-by: Johannes Schindelin <johannes.schinde...@gmx.de>
Signed-off-by: Pranit Bauva <pranit.ba...@gmail.com>
Signed-off-by: Tanushree Tumane <tanushreetum...@gmail.com>
---
 builtin/bisect--helper.c | 11 +----------
 1 file changed, 1 insertion(+), 10 deletions(-)

diff --git a/builtin/bisect--helper.c b/builtin/bisect--helper.c
index 6a1920d3e7..6cd74049e8 100644
--- a/builtin/bisect--helper.c
+++ b/builtin/bisect--helper.c
@@ -21,7 +21,6 @@ static GIT_PATH_FUNC(git_path_bisect_names, "BISECT_NAMES")
 
 static const char * const git_bisect_helper_usage[] = {
        N_("git bisect--helper --bisect-reset [<commit>]"),
-       N_("git bisect--helper --bisect-write [--no-log] <state> <revision> 
<good_term> <bad_term>"),
        N_("git bisect--helper --bisect-check-and-set-terms <command> 
<good_term> <bad_term>"),
        N_("git bisect--helper --bisect-next-check <good_term> <bad_term> 
[<term>]"),
        N_("git bisect--helper --bisect-terms [--term-good | --term-old | 
--term-bad | --term-new]"),
@@ -1015,7 +1014,6 @@ int cmd_bisect__helper(int argc, const char **argv, const 
char *prefix)
 {
        enum {
                BISECT_RESET = 1,
-               BISECT_WRITE,
                CHECK_AND_SET_TERMS,
                BISECT_NEXT_CHECK,
                BISECT_TERMS,
@@ -1031,8 +1029,6 @@ int cmd_bisect__helper(int argc, const char **argv, const 
char *prefix)
        struct option options[] = {
                OPT_CMDMODE(0, "bisect-reset", &cmdmode,
                         N_("reset the bisection state"), BISECT_RESET),
-               OPT_CMDMODE(0, "bisect-write", &cmdmode,
-                        N_("write out the bisection state in BISECT_LOG"), 
BISECT_WRITE),
                OPT_CMDMODE(0, "check-and-set-terms", &cmdmode,
                         N_("check and set terms in a bisection state"), 
CHECK_AND_SET_TERMS),
                OPT_CMDMODE(0, "bisect-next-check", &cmdmode,
@@ -1072,12 +1068,7 @@ int cmd_bisect__helper(int argc, const char **argv, 
const char *prefix)
        case BISECT_RESET:
                if (argc > 1)
                        return error(_("--bisect-reset requires either no 
argument or a commit"));
-               return !!bisect_reset(argc ? argv[0] : NULL);
-       case BISECT_WRITE:
-               if (argc != 4 && argc != 5)
-                       return error(_("--bisect-write requires either 4 or 5 
arguments"));
-               set_terms(&terms, argv[3], argv[2]);
-               res = bisect_write(argv[0], argv[1], &terms, nolog);
+               res = bisect_reset(argc ? argv[0] : NULL);
                break;
        case CHECK_AND_SET_TERMS:
                if (argc != 3)
-- 
gitgitgadget