Hi Rohit, On Wed, 27 Feb 2019, Rohit Ashiwal wrote:
> On Tue, Feb 26, 2019 at 10:07 PM SZEDER Gábor <[email protected]> wrote: > > > Furthermore, there are a couple of place where the '!' is not in front > > of the whole 'test' command but is given as an argument, e.g.: > > > > test ! -f file > > > > Please convert those cases as well. > > I think since I'm modifying `test_path_is_{dir|file}` functions to > handle calls like `! test_path_is_dir` well as mentioned in this > thread[1]. I think we should replace `! test` calls with `test !`, so > that the changes are in agreement with each other. What do you say? I think what Gábor meant was that both `test ! -f file` and `! test -f file` should be converted to `test_path_is_missing file`. Ciao, Johannes
