On Thu, Feb 07, 2013 at 10:05:26AM +0100, Michael J Gruber wrote:

> > Would it be better if object_array_entry replaced its "mode" member with
> > an object_context?
> 
> Do all callers/users want to deal with object_context?

Wouldn't it just mean replacing "entry->mode" with "entry->oc.mode" at
each user?

> I'm wondering why o_c has a mode at all, since it is mostly used in
> conjunction with an object, isn't it?

Just as we record the path from the surrounding tree, we record the
mode. It's that mode which gets put into the pending object list by the
revision parser (see the very end of handle_revision_arg). Storing an
object_context instead of the mode would be a strict superset of what we
store now (right now we just throw the rest away).

-Peff
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to