On Thu, Feb 07, 2013 at 10:34:26AM +0100, Michael J Gruber wrote: > > Just as we record the path from the surrounding tree, we record the > > mode. It's that mode which gets put into the pending object list by the > > revision parser (see the very end of handle_revision_arg). Storing an > > object_context instead of the mode would be a strict superset of what we > > store now (right now we just throw the rest away). > > Sure. But why does object_context have a mode member at all? Maybe it is > not alway used together with another struct which has the mode already, > then that's a reason.
Exactly. It's purely for pulling information out of get_sha1_with_context, and does not know that you are going to put its output into an object_array_entry (and many call sites do not). -Peff -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
