Brandon Casey <bca...@nvidia.com> writes: >>> + return len > strlen(cherry_picked_prefix) + 1 && >>> + !prefixcmp(buf, cherry_picked_prefix) && buf[len - 1] == ')'; >>> +} >> >> Does the first "is it longer than the prefix?" check matter? If it >> is not, prefixcmp() would not match anyway, no? > > Probably not in practice, but technically we should only be accessing > len characters in buf even though buf may be longer than len. So the > check is just making sure the function doesn't access chars it's not > supposed to.
Sorry, I do not follow. Isn't caller's buf terminated with LF at buf[len], which would never match cherry_picked_prefix even if len is shorter than the prefix? -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
