Jeff King <p...@peff.net> writes:

> Here it is with the updated expectation. I don't care _that_ much, so if
> you feel strongly and want to drop the first test, feel free.

As long as we are adding expect_failure without an immediate fix,
let's document the ideal, with this patch on top.

 t/t1300-repo-config.sh | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/t/t1300-repo-config.sh b/t/t1300-repo-config.sh
index 213e5a8..133f26d 100755
--- a/t/t1300-repo-config.sh
+++ b/t/t1300-repo-config.sh
@@ -1089,16 +1089,20 @@ test_expect_success 'barf on incomplete string' '
 
 # good section hygiene
 test_expect_failure 'unsetting the last key in a section removes header' '
        cat >.git/config <<-\EOF &&
+       # some generic comment on the configuration file itself
+       # a comment specific to this "section" section.
        [section]
        # some intervening lines
        # that should also be dropped
 
        key = value
        EOF
 
-       >expect &&
+       cat >expect <<-\EOF &&
+       # some generic comment on the configuration file itself
+       EOF
 
        git config --unset section.key &&
        test_cmp expect .git/config
 '
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to