On Sun, Mar 31, 2013 at 9:40 PM, Junio C Hamano <gits...@pobox.com> wrote:
> All the callers of "ask", "extract_valid_address", and "validate_patch"
> subroutines assign the return values from them to a single scaler:


(note the /g)

>         $var = subr(...);
> and "return undef;" in these subroutine can safely be turned into a
> simpler "return;".  Doing so will also future-proof a new caller that
> mistakenly does this:
>     @foo = ask(...);
>     if (@foo) { ... we got an answer ... } else { ... we did not ... }
> Note that we leave "return undef;" in validate_address on purpose,
> even though Perlcritic may complain.  The primary "return" site of
> the function returns whatever is in the scaler variable $address, so
> it is pointless to change only the other "return undef;" to "return".
> The caller must be prepared to see an array with a single undef as
> the return value from this subroutine anyway.
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to