Junio C Hamano wrote:
> Felipe Contreras <felipe.contre...@gmail.com> writes:
> > On Tue, Apr 2, 2013 at 1:58 PM, Junio C Hamano <gits...@pobox.com> wrote:
> >> Felipe Contreras <felipe.contre...@gmail.com> writes:
> >>
> >>> We can't use stdout for that in remote helpers.
> >>>
> >>> Signed-off-by: Felipe Contreras <felipe.contre...@gmail.com>
> >>> ---
> >>
> >> You may want to clarify "buggy output" a bit.  Will mercurial
> >> forever be broken?  Some versions of Hg emit [[[it is unclear for
> >> Junio to tell what it is to fill this blank]]] to its output that
> >> we want to ignore?
> >
> > The problem is that mercurial's code is kind of hardcoded to run under
> > mercurial's UI, so it throws messages around willynillingly, like:
> >
> > searching for changes
> > no changes found
> >
> > And they can't be turned off. Theoretically we could override
> > mercurial's UI class, but I think that has the potential to create
> > more problems, it's not worth at this point in time.
> Oh, I totally agree with you _after_ reading that explanation.
> You just shouldn't let me waste your time to explain that to me in
> this exchange, and you could have done so by writing a clearer log
> message.  That's all.

I saw that you update the commit message without consulting here first to:

remote-hg: redirect unnecessary mercurial output
Mercurial emits messages like "searching for changes", "no changes
found", etc. meant for the use of its own UI layer, which is of no
use for our remote helper.  Squelch them.

This is not correct. This patch does _not_ squelch the output, it's redirecting
it to standard error, so the user actually sees it now, and we do that not
because the output is "unnecessary", but because it *breaks* the pipe between
the transport helper and remote helper. I'll reroll with the updated commit 


Felipe Contreras
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to