On Thu, Apr 11, 2013 at 12:05:11PM +0100, Adam Spiers wrote:

> On Thu, Apr 11, 2013 at 01:25:53AM -0400, Jeff King wrote:
> > On Thu, Apr 11, 2013 at 02:59:31AM +0100, Adam Spiers wrote:
> > > -static int check_ignore(const char *prefix, const char **pathspec)
> > > +static int check_ignore(struct path_exclude_check check,
> > > +                 const char *prefix, const char **pathspec)
> > 
> > Did you mean to pass the struct by value here? If it is truly a per-path
> > [...]
> It's not a per-path value; it's supposed to be reused across checks
> for multiple paths, as explained in the comments above
> last_exclude_matching_path():

Makes sense (I didn't look into it very far, and was just guessing based
on the pass-by-value). Passing a pointer is definitely the right fix,


To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to