On Tue, Apr 16, 2013 at 2:19 PM, Junio C Hamano <gits...@pobox.com> wrote: > Felipe Contreras <felipe.contre...@gmail.com> writes: > >> Sure, and where is the thinking not clear? The remote helper ref is >> not updated, so we do update it. How is that not clear? > > Sure, between "leaving it untouched, keeping the stale value" and > "updating it to match what was pushed", everybody would know you > mean the latter when you say "correctly update". There is no third > option "updating it to match a random commit that is related to but > is not exactly the same as what was pushed" to be correct. > > What I felt unclear was _why_ both of these two (remote and testgit) > have to get updated. In other words, "correctly update it" because > "without doing so, these bad things X, Y and Z will happen".
The bad thing that would happen is that it won't be up-to-date. If you don't know what an outdated ref causes, then you don't know what transport-helper does with it, and if you don't know that, why are you bothering trying to review this patch? Is the purpose of a patch to educate people? Here it goes. The remote helper ref is going to be used to tell fast-export which refs to negate (e.g. ^refs/testgit/origin/master), so that extra commits are not generated, which the remote helper should ignore anyway, because it should already have marks for those. So doing two consecutive pushes, would push the commits twice. It's worth noting this is the first time anybody asks what is the negative effect of this not getting fixed. Cheers. -- Felipe Contreras -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
