Michael J Gruber <g...@drmicha.warpmail.net> writes:

> This series teaches show and grep to obey textconv: show by
> default (like diff), grep only on request (--textconv).  We might
> switch the default for the latter also, of course.  I'd actually
> like that.
> Compared to an earlier (historic) series this one comes with tests.

It would have been nicer if you referred to the previous thread



>   grep: allow to use textconv filters

This looked mostly sensible except for one minor "eh, do we really
need to assume textconv output is text, or wouldn't using the same
codepath for raw blob and textconv result to make them consistently
honor opt->binary easier to explain?".

>   t4030: demonstrate behavior of show with textconv
>   t7008: demonstrate behavior of grep with textconv

It somehow felt they are better together in the patches that
implement the features they exercise.

>   show: obey --textconv for blobs
>   cat-file: do not die on --textconv without textconv filters
>   grep: obey --textconv for the case rev:path

I just let my eyes coast over these but didn't see anything
obviously wrong.

By the way, "git log --no-merges | grep obey | wc -l" shows that we
say "honor an option" a lot more than "obey an option".  We may want
to be consistent here.
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to