On Fri, Apr 19, 2013 at 11:24:16AM -0700, Junio C Hamano wrote: > > grep: allow to use textconv filters > > This looked mostly sensible except for one minor "eh, do we really > need to assume textconv output is text, or wouldn't using the same > codepath for raw blob and textconv result to make them consistently > honor opt->binary easier to explain?".
I don't mind re-checking the textconv output for binary-ness. But I did it that way for consistency with the diff code-path, which also assumes that textconv output is not binary. > By the way, "git log --no-merges | grep obey | wc -l" shows that we > say "honor an option" a lot more than "obey an option". We may want > to be consistent here. Yeah, it is a pretty minor thing, but I agree that "honor" sounds better. -Peff -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
