When there are lots of items to be cleaned, it is hard to see them all
in one screen. Show them in columns instead of in one column will solve
this problem.

Since no longer show items to be cleaned using the "Would remove ..."
format (only plain filenames) in interactive mode, we add instructions
and warnings as header before them.

Signed-off-by: Jiang Xin <worldhello....@gmail.com>
Comments-by: Matthieu Moy <matthieu....@imag.fr>
---
 Documentation/config.txt |  4 ++++
 builtin/clean.c          | 58 +++++++++++++++++++++++++++++++++---------------
 2 files changed, 44 insertions(+), 18 deletions(-)

diff --git a/Documentation/config.txt b/Documentation/config.txt
index 6e53f..98bfa 100644
--- a/Documentation/config.txt
+++ b/Documentation/config.txt
@@ -955,6 +955,10 @@ column.branch::
        Specify whether to output branch listing in `git branch` in columns.
        See `column.ui` for details.
 
+column.clean::
+       Specify whether to output cleaning files in `git clean -i` in columns.
+       See `column.ui` for details.
+
 column.status::
        Specify whether to output untracked files in `git status` in columns.
        See `column.ui` for details.
diff --git a/builtin/clean.c b/builtin/clean.c
index 29fbf..43383 100644
--- a/builtin/clean.c
+++ b/builtin/clean.c
@@ -13,11 +13,13 @@
 #include "refs.h"
 #include "string-list.h"
 #include "quote.h"
+#include "column.h"
 
 static int force = -1; /* unset */
 static int interactive;
 static struct string_list del_list = STRING_LIST_INIT_DUP;
 static const char **the_prefix;
+static unsigned int colopts;
 
 static const char *const builtin_clean_usage[] = {
        N_("git clean [-d] [-f] [-i] [-n] [-q] [-e <pattern>] [-x | -X] [--] 
<paths>..."),
@@ -32,8 +34,13 @@ static const char *msg_warn_remove_failed = N_("failed to 
remove %s");
 
 static int git_clean_config(const char *var, const char *value, void *cb)
 {
-       if (!strcmp(var, "clean.requireforce"))
+       if (!prefixcmp(var, "column."))
+               return git_column_config(var, value, "clean", &colopts);
+
+       if (!strcmp(var, "clean.requireforce")) {
                force = !git_config_bool(var, value);
+               return 0;
+       }
        return git_default_config(var, value, cb);
 }
 
@@ -145,6 +152,33 @@ static int remove_dirs(struct strbuf *path, const char 
*prefix, int force_flag,
        return ret;
 }
 
+void pretty_print_dels()
+{
+       struct string_list list = STRING_LIST_INIT_DUP;
+       struct string_list_item *item;
+       struct strbuf buf = STRBUF_INIT;
+       const char *qname;
+       struct column_options copts;
+
+       for_each_string_list_item(item, &del_list) {
+               qname = quote_path_relative(item->string, -1, &buf, 
*the_prefix);
+               string_list_append(&list, qname);
+       }
+
+       /*
+        * always enable column display, we only consult column.*
+        * about layout strategy and stuff
+        */
+       colopts = (colopts & ~COL_ENABLE_MASK) | COL_ENABLED;
+       memset(&copts, 0, sizeof(copts));
+       copts.indent = "  ";
+       copts.padding = 2;
+       print_columns(&list, colopts, &copts);
+       putchar('\n');
+       strbuf_release(&buf);
+       string_list_clear(&list, 0);
+}
+
 void edit_by_patterns_cmd()
 {
        struct dir_struct dir;
@@ -153,7 +187,6 @@ void edit_by_patterns_cmd()
        struct strbuf **ignore_list;
        struct string_list_item *item;
        struct exclude_list *el;
-       const char *qname;
        int changed = -1, i;
 
        while (1) {
@@ -166,12 +199,8 @@ void edit_by_patterns_cmd()
                if (changed) {
                        putchar('\n');
 
-                       /* Display dels in "Would remove ..." format */
-                       for_each_string_list_item(item, &del_list) {
-                               qname = quote_path_relative(item->string, -1, 
&buf, *the_prefix);
-                               printf(_(msg_would_remove), qname);
-                       }
-                       putchar('\n');
+                       /* Display dels in columns */
+                       pretty_print_dels();
                }
 
                printf(_("Input ignore patterns>> "));
@@ -228,23 +257,17 @@ void edit_by_patterns_cmd()
 void interactive_main_loop()
 {
        struct strbuf confirm = STRBUF_INIT;
-       struct strbuf buf = STRBUF_INIT;
-       struct string_list_item *item;
-       const char *qname;
 
        /* dels list may become empty after return back from edit mode */
        while (del_list.nr) {
+               putchar('\n');
                printf_ln(Q_("Would remove the following item:",
                             "Would remove the following items:",
                             del_list.nr));
                putchar('\n');
 
-               /* Display dels in "Would remove ..." format */
-               for_each_string_list_item(item, &del_list) {
-                       qname = quote_path_relative(item->string, -1, &buf, 
*the_prefix);
-                       printf(_(msg_would_remove), qname);
-               }
-               putchar('\n');
+               /* Display dels in columns */
+               pretty_print_dels();
 
                /* Confirmation dialog */
                printf(_("Remove ([y]es/[n]o/[e]dit) ? "));
@@ -274,7 +297,6 @@ void interactive_main_loop()
                }
        }
 
-       strbuf_release(&buf);
        strbuf_release(&confirm);
 }
 
-- 
1.8.3.rc1.338.gb35aa5d

--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to