Heiko Voigt <hvo...@hvoigt.net> writes:
> On Sun, May 12, 2013 at 09:56:39PM -0700, Junio C Hamano wrote:
>> Heiko Voigt <hvo...@hvoigt.net> writes:
>> > /*
>> > - * The fields f and name of top need to be initialized before calling
>> > + * All source specific fields in the union, name and the callbacks
>> > + * fgetc, ungetc, ftell of top need to be initialized before calling
>> > * this function.
>> > */
>> > -static int do_config_from(struct config_file *top, config_fn_t fn, void
>> > *data)
>> > +static int do_config_from_source(struct config_source *top, config_fn_t
>> > fn, void *data)
>> This renaming may have made sense if we were to have many different
>> do_config_from_$type functions for different types of source, but as
>> this patch introduces a nice "config_source" abstraction, I do not
>> think it is unnecessary. Shortening do_config_from() to do_config()
>> may make more sense, if anything.
>> But that is a very minor point, as this is entirely internal with a
>> single caller.
> Did you really intent this double negation: "..., I do not think it
> is unnecessary."
Eh, rather "I think it is unnecessary" or "I do not think it is
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html