On MinGW, sparse issues an "'get_st_mode_bits' not declared. Should
it be static?" warning. The MinGW and MSVC builds do not see the
declaration of this function, within git-compat-util.h, due to its
placement within an preprocessor conditional.

In order to suppress the warning, we simply move the declaration to
the top level of the header.

Signed-off-by: Ramsay Jones <ram...@ramsay1.demon.co.uk>

Hi Junio,

As promised, this fixes the build on cygwin. (tested on cygwin
and MinGW. I have not tested on Linux, because I would have to
re-boot twice, and I wanted to send this out tonight).

Again, sorry for breaking the build.

Ramsay Jones

 git-compat-util.h | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/git-compat-util.h b/git-compat-util.h
index 660b7f0..aa0404e 100644
--- a/git-compat-util.h
+++ b/git-compat-util.h
@@ -127,6 +127,9 @@
 #include <poll.h>
+extern int get_st_mode_bits(const char *path, int *mode);
 #if defined(__MINGW32__)
 /* pull in Windows compatibility stuff */
 #include "compat/mingw.h"
@@ -163,7 +166,6 @@
 typedef long intptr_t;
 typedef unsigned long uintptr_t;
-int get_st_mode_bits(const char *path, int *mode);
 #if defined(__CYGWIN__)
 #include <grp.h>

To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to