On Wed, May 29, 2013 at 10:52:58PM -0400, Jeff King wrote: > diff --git a/t/test-lib.sh b/t/test-lib.sh > index ca6bdef..5d84705 100644 > --- a/t/test-lib.sh > +++ b/t/test-lib.sh > @@ -600,7 +600,7 @@ fi > fi > > # Test repository > -TRASH_DIRECTORY="trash directory.$(basename "$0" .sh)" > +TRASH_DIRECTORY="trash directory:$(basename "$0" .sh)" > test -n "$root" && TRASH_DIRECTORY="$root/$TRASH_DIRECTORY" > case "$TRASH_DIRECTORY" in > /*) ;; # absolute path is good > > reveals the breakage on Linux. And it seems that a lot of other tests > break, too. I haven't looked into them yet, though.
Hrm. Just picking an example at random, t7006 fails because it uses --exec-path="`pwd`". And of course colons are meaningful in any PATH-like context. It would be nice to be able to handle that case cleanly, but I think we would be breaking compatibility. So while it would be nice to work on paths with colons everywhere, I doubt it is worth the effort to start checking it through the whole test suite. -Peff -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
