On Thu, Jun 6, 2013 at 1:37 AM, Jeff King <p...@peff.net> wrote:
> On Thu, Jun 06, 2013 at 08:34:41AM +0200, Johannes Sixt wrote:
>> From: Johannes Sixt <j...@kdbg.org>
>> The test case depends on that test-sigchain can commit suicide by a call
>> to raise(SIGTERM) in a way that run-command.c::wait_or_whine() can detect
>> as death through a signal. There are no POSIX signals on Windows, and a
>> sufficiently close emulation is not available in the Microsoft C runtime
>> (and probably not even possible).
>> The particular deficiency is that when a signal is raise()d whose SIG_DFL
>> action will cause process death (SIGTERM in this case), the
>> implementation of raise() just calls exit(3).
>> We could check for exit code 3 in addition to 143, but that would miss
>> the point of the test entirely. Hence, just skip it on Windows.
> Thanks. I wasn't quite clear on how the signal handling worked on
> Windows, but from your description, I agree there is not any point in
> running the test at all.

Shouldn't we clarify that Git exit codes only work on UNIX-like
operating systems?

Felipe Contreras
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to