On Mon, Jun 17, 2013 at 10:00 PM, Brandon Casey <bca...@nvidia.com> wrote:
> From: Brandon Casey <draf...@gmail.com>
>
> Curl requires that we manage any strings that we pass to it as pointers.
> So, we should not be overwriting this strbuf after we've passed it to
> curl.
>
> Additionally, it is unnecessary since we only prompt for the user name
> and password once, so we end up overwriting the strbuf with the same
> sequence of characters each time.  This is why in practice it has not
> caused any problems for git's use of curl; the internal strbuf char
> pointer does not change, and get's overwritten with the same string

s/get's/gets/

> each time.
>
> But it's unnecessary and potentially dangerous, so let's avoid it.
>
> Signed-off-by: Brandon Casey <draf...@gmail.com>
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to