"Michael S. Tsirkin" <[email protected]> writes: > Verify that author name is not duplicated if it matches > sender, even if it is in utf8. > > Signed-off-by: Michael S. Tsirkin <[email protected]> > ---
Hmph. There seems to be something wrong in the original message I received from you (look at Cc: line I have above, which was copied by my MUA from the message I am responding to). Visiting http://article.gmane.org/gmane.comp.version-control.git/228485/raw shows this gem: Cc: =?us-ascii?B?PT9VVEYtOD9xP1NaRURFUj0yMEc9QzM9QTFib3I/PQ==?= <[email protected]> Somebody is wrapping what "=?UTF-8?q?..." which you had already wrapped into "=?us-ascii?B..."??? In any case, I think Thomas's "first expect failure and then flip it, if you add test and fix as separate patches" is a good idea, and the change between the previous one and this seems to be only the last part of this test, so I'll tweak what I already have from the previous on 'pu' locally and push the result out. Please double check the result. Thanks. > t/t9001-send-email.sh | 14 ++++++++++++++ > 1 file changed, 14 insertions(+) > > diff --git a/t/t9001-send-email.sh b/t/t9001-send-email.sh > index 9f46f22..020acc4 100755 > --- a/t/t9001-send-email.sh > +++ b/t/t9001-send-email.sh > @@ -956,6 +956,20 @@ test_expect_success $PREREQ 'utf8 author is correctly > passed on' ' > grep "^From: Füñný Nâmé <[email protected]>" msgtxt1 > ' > > +test_expect_success $PREREQ 'utf8 sender is not duplicated' ' > + clean_fake_sendmail && > + test_commit weird_sender && > + test_when_finished "git reset --hard HEAD^" && > + git commit --amend --author "Füñný Nâmé <[email protected]>" && > + git format-patch --stdout -1 >funny_name.patch && > + git send-email --from="Füñný Nâmé <[email protected]>" \ > + [email protected] \ > + --smtp-server="$(pwd)/fake.sendmail" \ > + funny_name.patch && > + grep "^From:" msgtxt1 > msgfrom && > + test_line_count = 1 msgfrom > +' > + > test_expect_success $PREREQ 'sendemail.composeencoding works' ' > clean_fake_sendmail && > git config sendemail.composeencoding iso-8859-1 && -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
