I have pondered these items:

On Jul 12, 2013, at 11:48, Junio C Hamano wrote:
Perhaps we should fix it as a preparatory patch (1/2) before the
main "feature addition" patch.



On Jul 12, 2013, at 11:52, Junio C Hamano wrote:
Subject: [PATCH] http.c: fix parsing of http.sslCertPasswordProtected variable

On Jul 14, 2013, at 21:02, Junio C Hamano wrote:
Assuming that Aaron and Peff's enhancement will not be a backward
incompatible update, my preference is to take the posted matching
semantics as-is (you may have some other changes that does not
change the "strictly textual match" semantics).

And in response I have previously sent out a combined v5 patch that has:

0001: your preparatory http.sslCertPasswordProtected patch
0002: logically related GIT_SSL_CERT_PASSWORD_PROTECTED patch
0003: textual matching http.<url>.* patch
0004: url normalization matching http.<url>.*
0005: test for url normalization function

However, upon further consideration (I noticed that the preparatory patch and v4 of the textual matching patch made their way into pu), perhaps it would be more convenient for you if I re-released the following patch series:


[PATCH v5]: config: support http.<url>.* settings - (1) textual matching

* contains 0001 the same preparatory http.sslCertPasswordProtected
* contains 0002 the same v5 textual matching http.<url>.* patch


[PATCH v2]: config: support http.<url>.* settings - (2) url normalization

* contains 0001 url normalization matching with feedback updates
* contains 0002 url normalization test


[PATCH v1]: config: support http.<url>.* settings - (3) any user matching

* contains 0001 a new patch that extends (2) to include any user matching


And drop the GIT_SSL_CERT_PASSWORD_PROTECTED patch as while it's logically related to the http.sslCertPasswordProtected patch it's not logistically related since independent areas of the file are touched and it could be successfully applied before or after the other patches. It can go together with any forthcoming enable-only fix for GIT_SSL_CERT_PASSWORD_PROTECTED and other such environment variables or just be dropped entirely.

I do not, however, wish to create any additional maintainer work, so wanted to check with you before sending out any of the reissues.
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to