I presume that I should apply this change to my porting of git_mkstemps_mode() to tig. If there are no complaints about this for a couple of days I will do so.

REF: $gmane/229961

On 07/17/2013 03:29 PM, Junio C Hamano wrote:
Thomas Rast<tr...@inf.ethz.ch>  writes:
Thomas Rast<tr...@inf.ethz.ch>  writes:
From: "Dale R. Worley"<wor...@alum.mit.edu>

open() returns -1 on failure, and indeed 0 is a possible success value
if the user closed stdin in our process.  Fix the test.

Signed-off-by: Thomas Rast<tr...@inf.ethz.ch>

  wrapper.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/wrapper.c b/wrapper.c
index dd7ecbb..6a015de 100644
--- a/wrapper.c
+++ b/wrapper.c
@@ -322,7 +322,7 @@ int git_mkstemps_mode(char *pattern, int suffix_len, int 
                template[5] = letters[v % num_letters]; v /= num_letters;

                fd = open(pattern, O_CREAT | O_EXCL | O_RDWR, mode);
-               if (fd>  0)
+               if (fd>= 0)
                        return fd;
                 * Fatal error (EPERM, ENOSPC etc).

-Drew Northup
"As opposed to vegetable or mineral error?"
-John Pescatore, SANS NewsBites Vol. 12 Num. 59
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to