The previous commit added tests to show that index-pack
correctly bails in unrecoverable situations. There are some
situations where the data could be recovered, but it is not

  1. If we can break the cycle using an object from another
     pack via --fix-thin.

  2. If we can break the cycle using a duplicate of one of
     the objects found in the same pack.

Note that neither of these is particularly high priority; a
delta cycle within a pack should never occur, and we have no
record of even a buggy git implementation creating such a

However, it's worth adding these tests for two reasons. One,
to document that we do not currently handle the situation,
even though it is possible. And two, to exercise the code
that runs in this situation; even though it fails, by
running it we can confirm that index-pack detects the
situation and aborts, and does not misbehave (e.g., by
following the cycle in an infinite loop).

In both cases, we hit an assert that aborts index-pack.

Signed-off-by: Jeff King <>
 t/ | 18 ++++++++++++++++++
 1 file changed, 18 insertions(+)

diff --git a/t/ b/t/
index 9b3f2c3..38e1809 100755
--- a/t/
+++ b/t/
@@ -56,4 +56,22 @@ test_expect_success 'index-pack detects REF_DELTA cycles' '
        test_must_fail git index-pack --fix-thin --stdin <cycle.pack
+test_expect_failure 'failover to an object in another pack' '
+       clear_packs &&
+       git index-pack --stdin <ab.pack &&
+       git index-pack --stdin --fix-thin <cycle.pack
+test_expect_failure 'failover to a duplicate object in the same pack' '
+       clear_packs &&
+       {
+               pack_header 3 &&
+               pack_obj $A $B &&
+               pack_obj $B $A &&
+               pack_obj $A
+       } >recoverable.pack &&
+       pack_trailer recoverable.pack &&
+       git index-pack --fix-thin --stdin <recoverable.pack

To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to
More majordomo info at

Reply via email to