This is a re-roll of [1] which fixes a bug in dir.c resulting in failure of a newly added test in t3010 when core.ignorecase=true.
Recent mailing list discussion [2][3] suggests that changes at a more fundamental level (if they pan out) would be a more appropriate approach to resolving this bug. Such an approach would (happily) make patch 2/2 unnecessary, however, I'm posting this series for posterity since it was already written before [2][3]. Also, since I'm learning the relevant git internals as I work on these issues, any fix at the more fundamental level (if it comes from me) is going to be correspondingly delayed since there is so much more to digest. Changes since v1: patch 1: place the new test in t3010 instead of t3103 [4] patch 2: make directory_exists_in_index() and directory_exists_in_index_icase() responsible for their own internal requirements regarding presence or lack of trailing '/' [5]; also, pass in already-existing strbufs so that directory_exists_in_index_icase() doesn't have to make its own copy of the incoming string in order to append '/' [1]: http://thread.gmane.org/gmane.comp.version-control.git/232796 [2]: http://thread.gmane.org/gmane.comp.version-control.git/232727/focus=232813 [3]: http://thread.gmane.org/gmane.comp.version-control.git/232727/focus=232822 [4]: http://thread.gmane.org/gmane.comp.version-control.git/232796/focus=232814 [5]: http://thread.gmane.org/gmane.comp.version-control.git/232727/focus=232800 Eric Sunshine (2): t3103: demonstrate dir.c:treat_one_path() core.ignorecase failure dir: test_one_path: fix inconsistent behavior due to missing '/' dir.c | 42 +++++++++++++++++++++++-------------- t/t3010-ls-files-killed-modified.sh | 8 +++++++ 2 files changed, 34 insertions(+), 16 deletions(-) -- 1.8.4.rc4.557.g46c5bb2 -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
