On Sun, Aug 25, 2013 at 2:00 AM, Jonathan Nieder <jrnie...@gmail.com> wrote: > Eric Sunshine wrote: > >> Although undocumented, directory_exists_in_index_icase(dirname,len) >> unconditionally assumes the presence of a '/' at dirname[len] (despite >> being past the end-of-string). Callers are expected to respect > [...] >> Fix this problem. > > So, does this fix the problem by changing > directory_exists_in_index_icase() to be more liberal in what it > accepts, or callers to be more conservative in what they pass in?
It places the onus upon the caller. As mentioned in the cover letter , I was not happy with this solution. Junio felt likewise. A follow-up series  fixes both directory_exists_in_index() and directory_exists_in_index_icase() to be more liberal in what they accept, relieving the caller of the burden. By the time that series was posted, however, Junio and Peff had decided that a fix at a more fundamental level would be better (a conclusion with which I agree, but for which I do not yet have sufficient knowledge about git internals to implement). In the meantime, as an interim bug fix, Junio decided  to apply the patch to which you responded (but with an updated commit message). : http://thread.gmane.org/gmane.comp.version-control.git/232796 : http://thread.gmane.org/gmane.comp.version-control.git/232833 : http://thread.gmane.org/gmane.comp.version-control.git/232833/focus=232837 > Please forgive my laziness. I ask in order to save future readers the > time of digging into the code. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html