Benoit Person <> writes:

> Mediawiki introduced a new API for queries w/ more than 500 results in
> version 1.21. That change triggered an infinite loop while cloning a
> mediawiki with such a page.
> Fix that while still preserving the old behavior for old APIs.

That would be nice to explain a bit more here. Where did the infinite
loop come from? How does your patch fix it?

> For now, if the tests suite is run without the fix, the new test
> introduces an infinite loop. I am not sure if this should be handled ?
> (a timeout of some kind maybe ?)

If the patch fix this, then it's not a really big problem. The test
failure is an infinite loop. That would be problematic if ran
non-interactively, but I think it's Ok since we only run the testsuite

> diff --git a/contrib/mw-to-git/git-remote-mediawiki.perl 
> b/contrib/mw-to-git/git-remote-mediawiki.perl
> index c9a4805..2d7af57 100755
> --- a/contrib/mw-to-git/git-remote-mediawiki.perl
> +++ b/contrib/mw-to-git/git-remote-mediawiki.perl
> @@ -625,6 +625,9 @@ sub fetch_mw_revisions_for_page {
>               rvstartid => $fetch_from,
>               rvlimit => 500,
>               pageids => $id,
> +
> +                # let the mediawiki knows that we support the latest API


> +                continue => '',

Indentation with spaces. Please, use tabs.

Matthieu Moy
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to
More majordomo info at

Reply via email to