On Sat, Sep 28, 2013 at 6:27 PM, Stefan Beller <stefanbel...@googlemail.com> wrote: > On 09/29/2013 12:04 AM, Felipe Contreras wrote: >> We are not calling any git commands any more. >> >> Signed-off-by: Felipe Contreras <felipe.contre...@gmail.com> >> --- >> git-request-pull.rb | 2 -- >> 1 file changed, 2 deletions(-) >> >> diff --git a/git-request-pull.rb b/git-request-pull.rb >> index fde8d1a..941ff72 100755 >> --- a/git-request-pull.rb >> +++ b/git-request-pull.rb >> @@ -2,8 +2,6 @@ >> >> require 'date' >> >> -ENV['GIT_PAGER'] = >> - >> patch = nil >> >> def usage >> > > Could this be squashed into the patch introducing the ENV? > (I assume that patch is among the 44 patches?)
It could be, but when ENV['GIT_PAGER'] was introduced, there were 'git foo' commands being called, so they would get a different $GIT_PAGER if we do so, which would be a change from the original script. To be honest I don't know what that code is trying to achieve, but to err on the side of caution I'm leaving the code close to the original. -- Felipe Contreras -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
