On 22.01.2014 20:58, Junio C Hamano wrote:
> The command line parser was broken when the command was
> reimplemented in C in two ways. It incorrectly limited the value
> range of window-memory and max-pack-size to "int", and also stopped
> grokking the unit suffixes like 2g/400m/8k.
> These two patches apply on top of 35c14176 (Reword repack
> documentation to no longer state it's a script, 2013-10-19) and
> later can be merged down to maint-1.8.4 track and upwards.
> Junio C Hamano (2):
> parse-options: refactor human-friendly-integer parser out of pack-objects
> repack: accept larger window-memory and max-pack-size
> builtin/pack-objects.c | 25 ++++---------------------
> builtin/repack.c | 12 ++++++------
> parse-options.c | 17 +++++++++++++++++
> parse-options.h | 5 +++++
> 4 files changed, 32 insertions(+), 27 deletions(-)
I recall we had a discussion about parsing as the shell script
just passed them on without altering the argument, while the new
c implementation parses the numbers already before passing them on.
thanks for such a quick patch. I'd currently have only little time
for open source contributions.
The patches seems reasonable to me.
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html