Torsten Bögershausen <> writes:

>> +int run_hook_with_custom_index(const char *index_file, const char *name, 
>> ...)
>> +{
>> +    const char *hook_env[3] =  { NULL };
>> +    char index[PATH_MAX];
> Sorry being late with the review.
> Recently some effort has been put to replace the
>  "PATH_MAX/snprintf() combo" with code using strbuf.
> So I think for new developed code it could make sense to avoid
> PATH_MAX from the start.

Yes but because this is a compatibility wrapper for an existing
function that does the string[PATH_MAX] thing already, it would be
clearer to have such a conversion as a separate step.

To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to
More majordomo info at

Reply via email to