Since fd0a8c2e (first appearing in v1.7.0), the
t/ test has used a backslash escape
inside a ${} expansion in order to specify a literal '?' character.

Unfortunately the FreeBSD /bin/sh does not interpret this correctly.

In a POSIX compliant shell, the following:

echo "${x#*\?}"

Would be expected to produce this:


When using the FreeBSD /bin/sh instead you get this:


In fact the FreeBSD /bin/sh treats the backslash as a literal
character to match so that this:

echo "${y#*\?}"

Produces this unexpected value:


In this case the backslash is not only treated literally, it also
fails to defeat the special meaning of the '?' character.

Instead, we can use the [...] construct to defeat the special meaning
of the '?' character and match it exactly in a way that works for the
FreeBSD /bin/sh as well as other POSIX /bin/sh implementations.

Changing the example like so:

echo "${x#*[?]}"

Produces the expected output using the FreeBSD /bin/sh.

Therefore, change the use of \? to [?] in order to be compatible with
the FreeBSD /bin/sh which allows t/ to
pass on FreeBSD again.

Signed-off-by: Kyle J. McKay <>

 t/ | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/t/ b/t/
index 9be9ae34..5abd11a5 100755
--- a/t/
+++ b/t/
@@ -9,8 +9,8 @@ test_have_prereq GREP_STRIPS_CR && export GREP_OPTIONS=-U
 run_backend() {
        echo "$2" |
-       QUERY_STRING="${1#*\?}" \
+       QUERY_STRING="${1#*[?]}" \
        git http-backend >act.out 2>act.err
tg: (532c2992..) t/freebsd-t5560 (depends on: t/revert-99855ddf)
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to
More majordomo info at

Reply via email to