Marat Radchenko wrote:
> +# Define CROSS_COMPILE to specify the prefix used for all executables used
> +# during compilation. Only gcc and related bin-utils executables
> +# are prefixed with $(CROSS_COMPILE).
Please include an example.
# Define CROSS_COMPILE=foo- if your compiler and binary utilities
# are foo-cc, foo-ar, foo-strip, etc. More specific variables
# override this, so if you set CC=gcc CROSS_COMPILE=ia64-linux-gnu-
# then the compiler will be 'gcc', not 'ia64-linux-gnu-gcc'.
Otherwise unless I happen to know the convention from other packages I
would not know whether to include a trailing '-' in CROSS_COMPILE,
Does the effect of this setting depend on whether CC=gcc (i.e., is the
Makefile checking the value of CC and ignoring CROSS_COMPILE when it
is e.g. the Intel compiler)?
> -STRIP ?= strip
> +STRIP = $(CROSS_COMPILE)strip
Before, STRIP from the environment took precedence over STRIP from the
makefile. Switching to the more usual 'environment can't be trusted'
convention is a good change, but please mention it in the commit
The rest looks good from a quick look.
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html