On Mon, Apr 28, 2014 at 11:31 AM, Junio C Hamano <gits...@pobox.com> wrote:
> Erik Faye-Lund <kusmab...@gmail.com> writes:
>> We're using Curl 7.30.0 in msysGit (and thus also Git for Windows), so
>> we should be able to include it. However, we do not have curl-config
>> installed.
> Hmmm, between 2.0-rc0 and 2.0-rc1 there is 61a64fff (Makefile: use
> curl-config to determine curl flags, 2014-04-15) merged already,
> which makes this assumption and a claim based on that assumption:
>     curl-config should always be installed alongside a curl
>     distribution, and its purpose is to provide flags for building
>     against libcurl, so use it instead of guessing flags and
>     dependent libraries.
> which may make things worse for you guys, unless you are explicitly
> setting CURLDIR and other Makefile variables.

Yes, I can see that assumption may not always hold. But I'm slightly
surprised this worked in the first place; are you saying this is a
system where:
-curl-config is not installed
-but -lcurl still works
-without setting CURLDIR

I think I should probably re-roll the patch to default to the old
behavior (blind -lcurl) if curl-config returns the empty string, which
I believe is also the case when the binary is not found.
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to