Dave Borowitz wrote:
> On Mon, Apr 28, 2014 at 1:05 PM, Jonathan Nieder <jrnie...@gmail.com> wrote:
>> Dave Borowitz wrote:
>>> +++ b/Makefile
>>> @@ -35,7 +35,9 @@ all::
>>> # transports (neither smart nor dumb).
>>> # Define CURL_CONFIG to the path to a curl-config binary other than the
>>> -# default 'curl-config'.
>>> +# default 'curl-config'. If CURL_CONFIG is unset or points to a binary that
>>> +# is not found, defaults to the CURLDIR behavior, or if CURLDIR is not set,
>>> +# uses -lcurl with no additional library detection.
>> I'm having a little trouble parsing this but don't have any better
> How about:
> "If CURL_CONFIG is unset or points to a binary that is not found,
> defaults to the CURLDIR behavior. If CURLDIR is not set, this means
> using -lcurl with no additional library detection (other than
Yep, that's clearer.
>>> - $(error libcurl not detected; try setting
>>> + $(error libcurl not detected or not
>>> compiled with static support)
>> Whitespace damage.
> Yes, but intentional, because Makefile parsing is weird.
> $ echo -e 'ifndef FOO\n\t$(error bad things)\nendif\n\nfoo:\n\ttouch
> foo' > mk1 && make -f mk1 foo
> mk1:2: *** commands commence before first target. Stop.
> $ echo -e 'ifndef FOO\n $(error bad things)\nendif\n\nfoo:\n\ttouch
> foo' > mk2 && make -f mk2 foo
> mk2:2: *** bad things. Stop.
Gah. Maybe it should be left-justified to avoid accentally breaking
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html