On Mon, Apr 28, 2014 at 08:00:04PM -0700, Dan Albert wrote:
> > I noticed that we are just filling in the password here, since we'll
> > always fill cred.username from srvc->user. The lines directly above are:
> >
> > if (!srvc->user) {
> > fprintf(stderr, "Skipping server %s, no user\n",
> > srvc->host);
> > goto bail;
> > }
> >
> > That comes from the imap.user config variable. I wonder if we should
> > just pass it off to credential_fill() in this case, too, which will fill
> > in the username if necessary.
> [...]
>
> Yeah, doubtful anyone cares, but it's simple enough to do.
Thanks, I think the result looks good.
Acked-by: Jeff King <[email protected]>
-Peff
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
