On 5 May 2014 15:08:04 GMT+10:00, Jeff King <p...@peff.net> wrote:
>On Sat, May 03, 2014 at 10:49:30PM +1000, James Denholm wrote:
>> The main issues are that calls are made to git itself in the build
>> process, and that a subtree-exclusive variable is used for specifying
>> the exec path. Patches 1/5 through 3/5 resolve these.
>> The "cleanup" fixes (4/5 and 5/5) are based on precedents set by
>> makefiles across the project.
>Thanks, these all look sane to me (I do not use subtree, but since it's
>just about Makefiles, it was pretty easy to review).

Thanks for the review!

Given that subtree subtree doesn't really generate a lot of discussion,
would it be advisable to wrap this up (barring further discussion) and send
it off to Junio rather than waiting for further community consensus?

James Denholm.
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to