Junio C Hamano wrote:
> dtur...@twopensource.com writes:

>> +    test -e testcase
> Please make it a habit to use "test -f" when you expect "the path
> exists as a file", not merely "something exists there I do not care
> if it is a file or a directory", for which "test -e" is perfectly
> appropriate.

Or, better in tests,

        test_path_is_file testcase

which prints an error instead of just silently failing when
the path is not a file.

To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to