On Tue, May 13, 2014 at 6:52 PM, Erik Faye-Lund <kusmab...@gmail.com> wrote:
> On Tue, May 13, 2014 at 1:15 PM, Nguyễn Thái Ngọc Duy <pclo...@gmail.com> 
> wrote:
>> diff --git a/Makefile b/Makefile
>> index 028749b..98d22de 100644
>> --- a/Makefile
>> +++ b/Makefile
>> @@ -1502,6 +1502,12 @@ ifdef HAVE_DEV_TTY
>>         BASIC_CFLAGS += -DHAVE_DEV_TTY
>>  endif
>>
>> +ifdef HAVE_SHM
>> +       BASIC_CFLAGS += -DHAVE_SHM
>> +       EXTLIBS += -lrt
>> +       PROGRAM_OBJS += read-cache--daemon.o
>> +endif
>> +
>
> I think read-cache--daemon will fail in case of NO_UNIX_SOCKETS.
>
> But, read-cache--daemon.c only gets compiled if we have shm_open...

Portability is something to be sorted out.Ideally we should not build
this unless we have both unix socket and shared memory support. On
Windows, I'm not sure how much code can be shared, or it'll be a
completely different program. In that case maybe this program should
be read-cache--daemon-posix (at least the .c file name, the binary may
be still git-read-cache--daemon) or something and the Windows version
read-cache--daemon-windows..
-- 
Duy
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to