Tanay Abhra <tanay...@gmail.com> writes:

>  test_expect_success 'find value with misspelled key' '
> -     echo "Value not found for \"my.fOo Bar.hi\"" >expect &&
> -     test_must_fail test-config get_value "my.fOo Bar.hi" >actual &&
> -     test_cmp expect actual
> +     check "my.fOo Bar.hi" "Value not found for \"my.fOo Bar.hi\""
>  '

This one is wrong: you did need the test_must_fail here.

(That's related to my other message about &&-chaining in check)

Other than my minor remarks, the patches now sounds good. Tanay: you
should be able to send a v7 very soon, and it should hopefully be ready
for pu.

Matthieu Moy
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to