Erik Faye-Lund <kusmab...@gmail.com> writes: > On Thu, Jul 17, 2014 at 5:37 PM, Stepan Kasal <ka...@ucw.cz> wrote: >> From: Pat Thoyts <pattho...@users.sourceforge.net> >> >> On Windows the application command line is provided as unicode and in >> mingw-git we convert that to utf-8. So these tests that require a iso-8859-1 >> input are being subverted by the encoding transformations we perform and >> should be skipped. >> ... >> -test_expect_success 'log --grep searches in log output encoding (latin1)' ' >> +test_expect_success NOT_MINGW 'log --grep searches in log output encoding >> (latin1)' ' >> cat >expect <<-\EOF && >> latin1 >> utf8 >> @@ -43,7 +43,7 @@ test_expect_success 'log --grep searches in log output >> encoding (latin1)' ' >> test_cmp expect actual >> ' >> >> -test_expect_success 'log --grep does not find non-reencoded values (utf8)' ' >> +test_expect_success NOT_MINGW 'log --grep does not find non-reencoded >> values (utf8)' ' > > Perhaps these checks would be more readable a few years in the future, > if we make a separate capability along the lines of > NON_UNICODE_LOCALE?
I do agree that having "unicode" and possibly also "locale" and dropping "mingw" from the prerequisite makes sense, especially in the longer term. Please make it so _after_ the dust settles. I however suspect that NON_UNICODE_LOCALE does not read quite well; isn't the trouble that mingw allows nothing but unicode strings on the command line (there is no trouble for non unicode strings that appear as payload)? Oh by the way, can somebody remind me why we spell these as NOT_MINGW, instead of !MINGW? -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
