Ronnie Sahlberg wrote:
> Add a new flag REFLOG_EMAIL_IS_COMMITTER to _update_reflog to tell it
> that what we pass in as email is already the fully baked committer string
> we can use as-is.
With and without the new flag, the 'email' argument has two different
* with the new flag, it should be an ident string, like
'Jonathan Nieder <jrnie...@gmail.com> 1406251347 -0700'
* without it, it should be the name-part of an ident string,
like 'Jonathan Nieder <jrnie...@gmail.com>
In neither case is it an email address. This seems unnecessarily
Is the caller responsible for checking the argument for validity?
Do callers do so? Is this performance-critical or could the
transaction_update_reflog function do a sanity-check?
> * Append a reflog entry for refname. If the REFLOG_TRUNCATE flag is set
> * this update will first truncate the reflog before writing the entry.
> * If msg is NULL no update will be written to the log.
> int transaction_update_reflog(struct ref_transaction *transaction,
> const char *refname,
> const unsigned char *new_sha1,
> const unsigned char *old_sha1,
> const char *email,
> unsigned long timestamp, int tz,
> const char *msg, int flags,
> struct strbuf *err);
This is a lot of parameters, some optional, not all documented. Would
it make sense to pack some into a struct?
Thanks and hope that helps,
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html