Ronnie Sahlberg wrote: > --- a/refs.c > +++ b/refs.c > @@ -2214,7 +2214,7 @@ static struct ref_lock *lock_ref_sha1_basic(const char > *refname, > */ > goto retry; > else > - unable_to_lock_index_die(ref_file, errno); > + goto error_return;
Should probably save last_errno so error_return can pass that information back. Can the caller recover from this error? Does it have enough information to produce the same helpful message as unable_to_lock_index_die? If this could be done without regressing behavior (e.g., by passing back error information as a message instead of through errno) then I think it would make sense. Jonathan -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
