Add test cases documenting the current behavior when trying to
add/append/edit empty notes. This is in preparation for adding
--allow-empty; to allow empty notes to be stored.

Improved-by: Eric Sunshine <sunsh...@sunshineco.com>
Improved-by: Junio C Hamano <gits...@pobox.com>
Signed-off-by: Johan Herland <jo...@herland.net>
---
 t/t3301-notes.sh | 27 +++++++++++++++++++++++++++
 1 file changed, 27 insertions(+)

diff --git a/t/t3301-notes.sh b/t/t3301-notes.sh
index cfd67ff..f74b3fa 100755
--- a/t/t3301-notes.sh
+++ b/t/t3301-notes.sh
@@ -1239,4 +1239,31 @@ test_expect_success 'git notes get-ref (--ref)' '
        test "$(GIT_NOTES_REF=refs/notes/bar git notes --ref=baz get-ref)" = 
"refs/notes/baz"
 '
 
+test_expect_success 'setup testing of empty notes' '
+       test_unconfig core.notesRef &&
+       test_commit 16th &&
+       empty_blob=$(git hash-object -w /dev/null)
+'
+
+while read cmd
+do
+       test_expect_success "'git notes $cmd' removes empty note" "
+               test_might_fail git notes remove HEAD &&
+               MSG= git notes $cmd &&
+               test_must_fail git notes list HEAD
+       "
+done <<\EOF
+add
+add -F /dev/null
+add -m ""
+add -c "$empty_blob"
+add -C "$empty_blob"
+append
+append -F /dev/null
+append -m ""
+append -c "$empty_blob"
+append -C "$empty_blob"
+edit
+EOF
+
 test_done
-- 
2.1.1.392.g062cc5d

--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to